Sunday, May 1, 2011

Streaming Data through Spring JDBC, unknown length

I currently have an application that inserts byte[] into our DB through the use of Spring JDBC [SqlLobValue]. The problem is, this is not a scalable way to take in data, as the server is buffering all the data in memory before writing to the database. I would like to stream the data from the HttpServletRequest Inputstream, but all the constructors I can find for any classes that take an Inputstream as an argument also require the content length as an argument. I do not, and will not, require the user to know the content length when POSTing data to my application. Is there a way around this limitation?

I can find no documentation about what happens if I pass -1 for content length, but my guess is it will throw an Exception. I'm not sure why they couldn't just have the stream keep reading until the read(...) returns -1, the required behavior of an InputStream.

From stackoverflow
  • I presume you meant "InputStream" rather than "OutputStream". I tried this out, but I was having bigger problems with my JDBC driver, so I am unsure if this actually works.

    InputStream inputStream = httpServletRequest.getInputStream();
    
    int contentLength = -1; // fake, will be ignored anyway
    SqlLobValue sqlLobValue = new SqlLobValue(
        inputStream,
        contentLength,
        new DefaultLobHandler() {
            public LobCreator getLobCreator() {
                return new DefaultLobHandler.DefaultLobCreator() {
                    public void setBlobAsBinaryStream(PreparedStatement ps, int paramIndex, InputStream binaryStream, int contentLength) throws SQLException {
                        // The contentLength parameter should be the -1 we provided earlier.
                        // You now have direct access to the PreparedStatement.
                        // Simply avoid calling setBinaryStream(int, InputStream, int)
                        // in favor of setBinaryStream(int, InputStream).
                        ps.setBinaryStream(paramIndex, binaryStream);
                    }
                };
            }
        }
    );
    
    jdbcTemplate.update(
        "INSERT INTO foo (bar) VALUES (?)",
        new Object[]{ sqlLobValue }
    );
    
    Gandalf : Much appreciated - that seems to do the trick. I did have to upgrade my Oracle JAR to ojdbc6.jar, seems the setBinaryStream(...) method w/o the length argument was added in Java 6. The older Oracle drivers would throw an AbstractMethodException.

0 comments:

Post a Comment